-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for BYOVPC for GCP #213
Open
gene-redpanda
wants to merge
12
commits into
main
Choose a base branch
from
byovpc-gcp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2,476
−562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b92d802
to
b191651
Compare
I apologize in advance for what you're going to see in this commit. So basically the terraform acceptance testing framework for the terraform plugin framework doesn't support the use of terraform modules. Yes, you read that right. In this context "doesn't support" means "will not delete any of the resources created by a module if the test fails". The module in question creates hundreds of resources so this isn't an ideal outcome. As a result I split the module out to a separate file and imported the arns of the essential created resources. This isn't ideal and isn't how end users should do this. I'm not sure how to square the circle on this one.
b191651
to
70af420
Compare
Also adds an email validator as that seemed sensible. I moved the aws elements of the cmr generate function into helper functions to improve readability of that enormous switch.
70af420
to
8198c5d
Compare
In some circumstances the API can return permission denied rather than not found for a resource that has been deleted. We handle it as a not found because * the user will be failing auth at a much earlier stage in the provider flow if their token is actually invalid * if we don't handle it as a not found we will incorrectly error on deleted resources
I added that tag when I was doing byoc testing work and didn't want to also hit the standard stuff when repeating the tests frequently. This is no longer necessary and is occasionally causing test duplication so away it goes!
It looks like there is a large rework for serverless required which is out of scope for this PR. It should still work, I will come back to it in a follow on PR.
8198c5d
to
fe3feb6
Compare
andrewstucki
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains a known issue regarding deprecated fields for serverless #214
Adds support for GCP BYOVPC. Validated cluster creation and destruction. Also has a supporting module which is going through a cleanup round.